Login Register






[VB.NET] Getting your own IP filter_list
Author
Message
RE: [VB.NET] Getting your own IP #4
(10-27-2015, 03:02 AM)respect Wrote:
(10-26-2015, 08:37 AM)Distance Wrote: getting your own ip in vb.net 

Code:
Private Function GetMyIP()         Dim ExternalIP As String = "Null"           Try             ExternalIP = (New WebClient()).DownloadString("http://checkip.dyndns.org/")             ExternalIP = (New Regex("\d{1,3}\.\d{1,3}\.\d{1,3}\.\d{1,3}")) _                          .Matches(ExternalIP)(0).ToString()         Catch exc As Exception             ExternalIP = "Null"         End Try           Return ExternalIP End Function

Way more work than needed but 1 main fix, this:
Code:
Dim ExternalIP As String = "Null"
Should be:
Code:
Dim ExternalIP As String
Or
Code:
Dim ExternalIP As String = ""
Or
Code:
Dim ExternalIP As String = null

there's no such thing as "null" in vb.net, VBNull is optional, but will return the Int 1 if it's returned in a function. Also, setting a string to "" is a bad habit, use String.Empty. Also, if this is all you've found you should look deeper, the error handling is terrible, its worthless. He should be doing other things than just setting the IP to "null", show a messagebox with the error, maybe have custom error handling etc.

Reply





Messages In This Thread
[VB.NET] Getting your own IP - by Distance - 10-26-2015, 08:37 AM