Thirteen Years of Service
Posts: 7,934
Threads: 708
RE: [Release] Basic Registration/Login system 12-27-2013, 06:58 AM
#2
If you ask me you should totes make it centered and fit the page so that way there isn't so much leftover room.
•
Thirteen Years of Service
Posts: 2,335
Threads: 194
RE: [Release] Basic Registration/Login system 12-27-2013, 12:08 PM
#3
Looks good, I may use this sometime. Nice release!
•
Twelve Years of Service
Posts: 13
Threads: 3
RE: [Release] Basic Registration/Login system 01-27-2014, 06:36 PM
#4
Looks really cool, I will totally use this!
•
Twelve Years of Service
Posts: 271
Threads: 17
RE: [Release] Basic Registration/Login system 02-23-2014, 06:54 AM
#5
Why are you comparing the return from mysqli_num_rows with "1" as a string? It returns an int unless the value returned to the caller is greater than PHP_INT_MAX, in which case it is a string, but if you compare it with "1" via the equality operator, obviously you're not anticipating it to be such a large numeric value... I'd use some more functions too and gather a collection of error codes that you can check against the function return values to be matched. Those nested if statements could definitely be cleaned up. I'd prefer to not use cookies either for various reasons.
edit: btw, it's not a good thing to be solely relying on mysqli_escape_string() to do all of the SQL injection prevention for you. I'd suggest you use Regex and match valid values that are allowed for the charset as input, as long as you know which ones are dangerous to include as valid.
•